Changes between Version 24 and Version 26 of Ticket #6957


Ignore:
Timestamp:
10/02/2018 10:37:56 PM (15 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6957

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to fixed
    • Property Blocking changed from 7000 to 6999, 7000
  • Ticket #6957 – Description

    v24 v26  
    88 
    99The cached default style sheet should be invalidated when the set of filters is updated. 
     10 
     11=== Hints for testers === 
     12Make sure that element hiding works correctly. 
     13 
     14For things to test specifically: 
     15 
     16* Add a filter for example.com, for example `example.com##h1`, then load example.com and see that the filter is applied (the element should be hidden and the DevTools panel should show the filter hit) 
     17* Remove the filter just added, then reload the page and see that the filer is no longer applied 
     18* Try the previous two steps again, but this time with a generic filter `##h1` (with no domain) 
     19* Add the generic filter `##h1`, then see that the `h1` element is hidden, then add an exception `example.com#@#h1`, then see that `h1` element on example.com is ''not'' hidden (but should be hidden on any other domain), then remove the exception and see that the `h1` element on example.com is hidden too 
     20* Remove all filters, then add the filter `com,~example.com##h1` and see that the `h1` element on example.com is not hidden (but should be hidden on any other .com domain) 
     21* Remove all filters, then add the filter `##h1` (no domain), then add the exception `com,~example.com#@#h1` and see that the `h1` element is hidden on example.com but ''not'' on any other .com domain (but should also be hidden on any other TLDs like .org, .net , and so on) 
     22* Remove all filters, then add the filter `~example.com##h1` and see that the `h1` element is hidden on all domains other than example.com 
     23 
     24This should be enough. 
     25 
     26Also see #6999.