Opened 14 months ago

Last modified 9 months ago

#6957 closed change

Return cached string object for unconditional style sheet — at Initial Version

Reported by: mjethani Assignee:
Priority: P3 Milestone:
Module: Core Keywords:
Cc: jsonesen, hfiguiere, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29886555/
https://codereview.adblockplus.org/29893618/
https://codereview.adblockplus.org/29893628/
https://codereview.adblockplus.org/29897558/

Description

Background

After #6956, the extension should ask core to generate a style sheet using the new createStyleSheet function. This is an opportunity to make sure that there is only one string object for the style sheet that is injected into most frames with no domain-specific filters or exceptions.

What to change

In createStyleSheet, check the argument passed in, and if it is the same as unconditionalSelectors then return a cached style sheet instead of generating a new one.

Change History (0)

Note: See TracTickets for help on using tickets.