Opened 14 months ago

Closed 3 months ago

#6959 closed change (rejected)

Switch to using async/await in core unit tests

Reported by: mjethani Assignee:
Priority: P4 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: erikvold Blocked By:
Blocking: #6425 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29984555/
https://codereview.adblockplus.org/29984577/
https://codereview.adblockplus.org/29984592/
https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/34

Description

Background

Async functions have been available at least since Node.js 8.x and we should start using them in our unit tests.

What to change

[TBD]

Change History (12)

comment:1 Changed 12 months ago by erikvold

  • Cc erikvold added

Probably worth doing when we convert from nodeunit to something else in Issue #6820.

comment:2 Changed 10 months ago by mjethani

  • Review URL(s) modified (diff)

comment:3 Changed 10 months ago by mjethani

  • Review URL(s) modified (diff)

comment:4 Changed 10 months ago by hfiguiere

  • Review URL(s) modified (diff)

comment:5 Changed 10 months ago by hfiguiere

  • Status changed from new to reviewing

comment:6 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/stub-modules/io.js

comment:7 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/filterStorage_readwrite.js

comment:8 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/browser/elemHideEmulation.js

comment:10 Changed 8 months ago by mjethani

  • Review URL(s) modified (diff)

comment:11 Changed 8 months ago by abpbot

A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/_common.js

comment:12 Changed 3 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from reviewing to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.