Opened 5 months ago

Last modified 12 days ago

#6959 reviewing change

Switch to using async/await in core unit tests

Reported by: mjethani Assignee:
Priority: P4 Milestone:
Module: Core Keywords:
Cc: erikvold Blocked By:
Blocking: #6425 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29984555/
https://codereview.adblockplus.org/29984577/
https://codereview.adblockplus.org/29984592/

Description

Background

Async functions have been available at least since Node.js 8.x and we should start using them in our unit tests.

What to change

[TBD]

Change History (9)

comment:1 Changed 3 months ago by erikvold

  • Cc erikvold added

Probably worth doing when we convert from nodeunit to something else in Issue #6820.

comment:2 Changed 5 weeks ago by mjethani

  • Review URL(s) modified (diff)

comment:3 Changed 5 weeks ago by mjethani

  • Review URL(s) modified (diff)

comment:4 Changed 5 weeks ago by hfiguiere

  • Review URL(s) modified (diff)

comment:5 Changed 5 weeks ago by hfiguiere

  • Status changed from new to reviewing

comment:6 Changed 5 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/stub-modules/io.js

comment:7 Changed 5 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/filterStorage_readwrite.js

comment:8 Changed 5 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/browser/elemHideEmulation.js

Note: See TracTickets for help on using tickets.