Opened 13 months ago

Closed 13 months ago

Last modified 12 months ago

#6962 closed change (fixed)

Update adblockplusui dependency to hg:0da3ee4abcad (release-2018-4.2)

Reported by: greiner Assignee: saroyanm
Priority: P2 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: wspee, saroyanm, sebastian, kzar, agiammarchi Blocked By: #6960, #6963
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29892557/

Description (last modified by kzar)

Background

This imports the follow changes:


And also import of the translations from the crowdin.

What to change

Change adblockplusui dependency to hg:0da3ee4abcad git:682d4d6

Hints for testers

  • Test that the options page works properly after it has been closed and reopened multiple times (#6960). See the testing instructions here.
  • Ensure that the issue reporter includes the Sources for filters - which is the filter list that they come from - in the final report it produces (#6963). See this issue for more information.
  • Test that the imported translations haven't broken the extension for other languages. It seems that the translations for most of the UI have been touched (Issue reporter, mobile options page, options page, popup, first run page, etc.)
  • Verify that the large "Block ads on" toggle button shows up in the popup window, on both Firefox and Chrome.
  • Verify that the numbered steps ("1 - Select issue" etc) show up at the top of the Issue reporter page, on both Firefox and Chrome.

Change History (23)

comment:1 Changed 13 months ago by greiner

  • Blocked By 6963 added

comment:2 Changed 13 months ago by greiner

  • Description modified (diff)

comment:3 Changed 13 months ago by greiner

  • Cc wspee added
  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to TBD (release-2018-4.2) to Update adblockplusui dependency to hg:TBD (release-2018-4.2)

comment:4 Changed 13 months ago by greiner

  • Blocked By 6960 added

comment:5 Changed 13 months ago by saroyanm

  • Cc saroyanm added

comment:6 Changed 13 months ago by saroyanm

  • Description modified (diff)

comment:7 Changed 13 months ago by saroyanm

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to hg:TBD (release-2018-4.2) to Update adblockplusui dependency to hg:0da3ee4abcad (release-2018-4.2)

comment:8 Changed 13 months ago by saroyanm

  • Priority changed from Unknown to P2
  • Ready set

comment:9 Changed 13 months ago by saroyanm

  • Description modified (diff)

comment:10 Changed 13 months ago by saroyanm

  • Description modified (diff)

comment:11 Changed 13 months ago by saroyanm

  • Description modified (diff)
  • Owner set to saroyanm

comment:12 Changed 13 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:13 follow-up: Changed 13 months ago by kzar

  • Cc sebastian kzar added
  • Description modified (diff)
  • Ready unset

How can the testers test this commit, or does it have no effect on the extension?

comment:14 Changed 13 months ago by kzar

  • Description modified (diff)

comment:15 Changed 13 months ago by kzar

  • Description modified (diff)

comment:16 Changed 13 months ago by agiammarchi

  • Cc agiammarchi added

comment:17 in reply to: ↑ 13 Changed 13 months ago by agiammarchi

Replying to kzar:

How can the testers test this commit, or does it have no effect on the extension?

If that wasn't in, Firefox wouldn't work (and neither Edge) so, basically, testing in both Chrome and Firefox would already implicitly validate that change was needed and it's working as meant.

The extension itself is not affected, the DOM / Custom Elements are.

The issue in a nutshell: polyfilled Custom Elements were not properly initialized due an issue with that library that has been fixed, and also, it's already 100% test covered.

Here to answer other questions, if needed.

Last edited 13 months ago by agiammarchi (previous) (diff)

comment:18 Changed 13 months ago by abpbot

A commit referencing this issue has landed:
Issue 6962 - Update adblockplusui dependency to hg:0da3ee4abcad

comment:19 follow-up: Changed 13 months ago by kzar

Could you give an example of something that wouldn't work in Adblock Plus for Firefox/Edge without that change? I'm still not too clear what it's about to be honest.

comment:20 in reply to: ↑ 19 Changed 13 months ago by agiammarchi

Replying to kzar:

Could you give an example of something that wouldn't work in Adblock Plus for Firefox/Edge without that change? I'm still not too clear what it's about to be honest.

Actually, I forgot I've also updated the underlying render library in there, because the one used in 3.0.1 had issues with the infinite scroll table so the core has been updated to be reliable in all cases.

As summary, 3.0.1 already fixed Custom Element issues, 3.1.0 made random thousands of dynamic changes reliable so there's really nothing new to test here, but having a more reliable render core shouldn't hurt anyone, right?

Tests to do:

  • be sure the big toggle button is visible in every target browser
  • verify the issue reporter top steps and canvas drawer show up

But if these tests were done already, nothing should've changed (and it has been tested that it shouldn't have so maybe you can ignore that change)

comment:21 Changed 13 months ago by kzar

  • Description modified (diff)
  • Ready set

Brilliant, thanks I've added those.

comment:22 Changed 13 months ago by sebastian

  • Milestone set to Adblock-Plus-3.4-for-Chrome-Opera-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:23 Changed 12 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. The Edge options page issue still needs testing when a build is available but the other issues (translations, popup toggle, issue reporter source/steps) are working as expected.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.