Changes between Version 1 and Version 2 of Ticket #6962, comment 17


Ignore:
Timestamp:
09/26/2018 03:49:59 PM (23 months ago)
Author:
agiammarchi
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6962, comment 17

    v1 v2  
    22> How can the testers test [https://github.com/adblockplus/adblockplusui/commit/f2eafca0d3ce94ccf8a21e1e12e265901f8131b4 this commit], or does it have no effect on the extension? 
    33 
    4 If that wasn't in, Firefox wouldn't work (and neither Edge) so, basically, testing in both Chrome and Firefox would already implicitly validate that change was needed. 
     4If that wasn't in, Firefox wouldn't work (and neither Edge) so, basically, testing in both Chrome and Firefox would already implicitly validate that change was needed and it's working as meant. 
     5 
     6The extension itself is not affected, the DOM / Custom Elements are. 
    57 
    68The issue in a nutshell: polyfilled Custom Elements were not properly initialized due an issue with that library that has been fixed, and also, it's already 100% test covered.