#6971 closed change (fixed)

Update regular expressions for resource type detection

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: diegocarloslima, jwangenheim, sergz Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29920555/
https://gitlab.com/eyeo/adblockplus/libadblockplus-android/merge_requests/5

Description

Background

Regular expressions are used to detect resource type in AdblockWebView:
https://github.com/adblockplus/libadblockplus-android/blob/master/adblock-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java#L92

We've updated them in AdblockChromium project
(as sometime we don't have information from Chromium and have to detect it with regexps):
https://github.com/adblockplus/chromium/pull/8/files#diff-88e0df9e94154fb3afe8d79ed070784fR90

What to change

Update regexps.

Change History (7)

comment:1 Changed 15 months ago by asmirnov

  • Summary changed from Update regex to Update regular expressions for resource type detection

comment:2 Changed 14 months ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 13 months ago by asmirnov

  • Review URL(s) modified (diff)

comment:4 Changed 13 months ago by asmirnov

  • Blocking 5140 added

comment:5 Changed 13 months ago by asmirnov

  • Blocking 5140 removed

comment:7 Changed 12 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.