Opened 13 months ago

Last modified 12 months ago

#6974 closed defect

Snippet filters don't work if ABP anti-circumvention filter list is removed and readded — at Version 1

Reported by: mjethani Assignee:
Priority: P1 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords: circumvention
Cc: sebastian, hfiguiere, greiner, amrmak Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mjethani)

Environment

Adblock Plus 3.4 pre-release (development build)

How to reproduce

  1. Do a fresh install of Adblock Plus
  2. Go to yandex.ru, search for "rent a car", and observe that there are no ads
  3. Open the options page and uncheck "ABP Anti-Circumvention Filter List", then recheck "ABP Anti-Circumvention Filter List"
  4. Repeat step 2

Observed behaviour

Ads are visible.

Expected behaviour

Ads should be hidden.

Additional notes

This happens because snippet filters will be used only if they come from the ABP anti-circumvention filter list, but this is determined at the time of installation from the subscriptions.xml file. When the UI readds the list, it doesn't set the type property of the Subscription object the way it is done during first run.

The proper fix would be for the UI to set the type property of the newly created Subscription object to "circumvention".

Note that before the change for #6855 you would not be able to reproduce this issue without restarting the extension before readding the anti-circumvention filter list; that change has only made the underlying issue more apparent, this is not a regression because of that change.

Change History (1)

comment:1 Changed 13 months ago by mjethani

  • Cc sebastian hfiguiere added
  • Description modified (diff)
Note: See TracTickets for help on using tickets.