Opened on 09/24/2018 at 07:33:26 AM

Closed on 09/24/2018 at 03:00:58 PM

Last modified on 10/16/2018 at 11:55:09 AM

#6975 closed change (fixed)

Check for specific anti-circumvention subscription URL

Reported by: mjethani Assignee: mjethani
Priority: P1 Milestone:
Module: Core Keywords:
Cc: sebastian, hfiguiere Blocked By:
Blocking: #6974 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mjethani)


See #6974.

If the type property of the Subscription object is not set to "circumvention", any snippet filters in the subscription are ignored. There should be a proper solution for this, but for now the code should additionally check for the specific URL of the anti-circumvention list. There's no downside to hardcoding the URL in the short term.

What to change

In lib/filterListener.js, in the addFilter function, check for the specific URL of the anti-circumvention list in addition to checking for the subscription type.

The URL to check for:

Add a test.

Hints for testers

Test that #6974 is fixed.

Also test that snippet filters from any other filter list than the ABP anti-circumvention filter list are silently ignored; user-defined snippet filters should work.

Attachments (0)

Change History (10)

comment:1 Changed on 09/24/2018 at 07:34:36 AM by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/24/2018 at 07:36:41 AM by mjethani

Hubert, are there supposed to be multiple anti-circumvention lists in the future?

comment:3 Changed on 09/24/2018 at 07:37:54 AM by mjethani

  • Blocking 6974 added

comment:4 Changed on 09/24/2018 at 12:29:16 PM by hfiguiere

The design is such that yes this is a possibility.

I'd rather fix the underlying problem than hardcode a URL.

comment:5 Changed on 09/24/2018 at 01:55:16 PM by mjethani

For now though, I mean for the 3.4 release, would hardcoding the URL be OK? We can fix this properly for 3.5.

comment:6 Changed on 09/24/2018 at 01:59:16 PM by mjethani

I've filed a follow-up issue #6977 for a proper fix.

comment:7 Changed on 09/24/2018 at 02:58:08 PM by abpbot

comment:8 Changed on 09/24/2018 at 03:00:58 PM by mjethani

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 09/24/2018 at 03:02:30 PM by abpbot

comment:10 Changed on 10/16/2018 at 11:55:09 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

This looks fixed (I think). Mainly tested by checking if the snippets appear in the devlog after removing/re-adding the subscription as some are being circumvented.

Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from mjethani.
Note: See TracTickets for help on using tickets.