Opened 7 months ago

Last modified 3 weeks ago

#6977 new change

Detect anti-circumvention filter list based on URL in subscriptions.xml

Reported by: mjethani Assignee:
Priority: P2 Milestone:
Module: Core Keywords:
Cc: hfiguiere, sergz, kzar, sebastian, greiner, tlucas Blocked By: #7371
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mjethani)


See #6974.

#6975 is a temporary fix for this issue just for the 3.4 release. There can be multiple anti-circumvention lists, it's not feasible to keep all the URLs hardcoded. Instead, it would be better to somehow get the URLs out of the subscriptions.xml file, which is already part of core.

Note: This also has to work for libadblockplus.

What to change


Change History (10)

comment:1 Changed 7 months ago by mjethani

  • Cc hfiguiere sergz added

comment:2 Changed 7 months ago by mjethani

  • Description modified (diff)

comment:3 Changed 7 months ago by mjethani

  • Cc kzar added

comment:4 Changed 7 months ago by sebastian

  • Cc sebastian added

comment:5 Changed 7 months ago by mjethani

  • Cc greiner added

comment:6 Changed 6 weeks ago by mjethani

  • Blocked By 7360 added

comment:7 Changed 4 weeks ago by sebastian

  • Blocked By 7371 added; 7360 removed

comment:8 Changed 4 weeks ago by greiner

Note that adblockplusui already relies on there only being one filter list of each type in subscriptions.xml (except for type=ads) so that it can uniquely associate them to the various UI elements that en-/disable them. Therefore we could either close this ticket since that assumption already exists in production or we could add a "recommended" flag to each <subscription> element that won't be set for any additional filter lists we're going to add later on (see also ui#196).

On another note, it might be a good idea to automatically validate that subscriptions.xml doesn't violate any of our assumptions. While we could do that in adblockplusui, adblockpluscore might be a better place for such a linter for the time being.

comment:9 Changed 4 weeks ago by mjethani

About the validation, I have suggested it in ticket:7371#comment:16.

comment:10 Changed 3 weeks ago by tlucas

  • Cc tlucas added
Note: See TracTickets for help on using tickets.