Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#698 closed change (fixed)

Create tests for $sitekey option

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: #406, #1687 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6612283790721024/

Description

Background

We have been using the $sitekey option for whitelisting multiple domains at once and will extend it with #431. So far tests for verifying the signature only exist in adblockpluschrome.

What to change

Add tests to the following test modules:

  • filterClasses
  • matcher
  • regexFilters_matching
  • policy

Additionally, include the "signatures" module from adblockpluschrome to test the signature verification.

Change History (5)

comment:1 Changed 3 years ago by greiner

  • Component changed from Extensions-for-Adblock-Plus to Adblock-Plus-for-Firefox
  • Platform set to Firefox/Firefox Mobile
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by greiner

  • Blocking 1687 added

comment:3 Changed 2 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 years ago by trev

  • Component changed from Adblock-Plus-for-Firefox to Extensions-for-Adblock-Plus

comment:5 Changed 2 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.