#6985 closed defect (fixed)
Running npm test fails on Windows for adblockpluschrome
Reported by: | geo | Assignee: | geo |
---|---|---|---|
Priority: | P3 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
Module: | Automation | Keywords: | |
Cc: | sebastian, Ross | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
Description
Environment
Windows 10
revision: git f2d0c16 hg e7abbf2e9d9b
nodejs: v8.11.3
How to reproduce
- Run npm install from PowerShell
- Run npm test from PowerShell
Observed behaviour
The script throws the following errors:
1) chrome "before all" hook: Error: The ChromeDriver could not be found on the current PATH. Please download the latest version of the ChromeDriver from http://chromedriver.storage.googleapis.com/index.html and ensure it can be found on your PATH. at new ServiceBuilder (node_modules\selenium-webdriver\chrome.js:215:13) at getDefaultService (node_modules\selenium-webdriver\chrome.js:304:22) at Function.createSession (node_modules\selenium-webdriver\chrome.js:752:44) at createDriver (node_modules\selenium-webdriver\index.js:170:33) at Builder.build (node_modules\selenium-webdriver\index.js:642:16) at Object.exports.getDriver (test\browsers\chromium.js:49:6) at Promise.all.then (test\all.js:53:30) at <anonymous> at process._tickCallback (internal/process/next_tick.js:188:7) 2) chrome "after all" hook: TypeError: Cannot read property 'quit' of undefined at Context.<anonymous> (test\all.js:80:19) 3) gecko "before all" hook: Error: The geckodriver.exe executable could not be found on the current PATH. Please download the latest version from https://github.com/mozilla/geckodriver/releases/ and ensure it can be found on your PATH. at findGeckoDriver (node_modules\selenium-webdriver\firefox\index.js:354:11) at new ServiceBuilder (node_modules\selenium-webdriver\firefox\index.js:446:22) at Function.createSession (node_modules\selenium-webdriver\firefox\index.js:516:21) at createDriver (node_modules\selenium-webdriver\index.js:170:33) at Builder.build (node_modules\selenium-webdriver\index.js:645:16) at Object.exports.getDriver (test\browsers\firefox.js:43:6) at Promise.all.then (test\all.js:53:30) at <anonymous> at process._tickCallback (internal/process/next_tick.js:188:7) 4) gecko "after all" hook: TypeError: Cannot read property 'quit' of undefined at Context.<anonymous> (test\all.js:80:19) npm ERR! code ELIFECYCLE npm ERR! errno 4 npm ERR! adblockpluschrome@ test-only: `mocha` npm ERR! Exit status 4 npm ERR! npm ERR! Failed at the adblockpluschrome@ test-only script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
Expected behaviour
The script should run without errors.
Change History (10)
comment:1 Changed 15 months ago by sebastian
- Cc Ross added
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed 15 months ago by sebastian
- Component changed from Platform to Automation
comment:3 Changed 15 months ago by geo
- Owner set to geo
comment:4 Changed 15 months ago by geo
- Review URL(s) modified (diff)
comment:5 Changed 15 months ago by abpbot
A commit referencing this issue has landed:
Issue 6985 - Running npm test fails on Windows for adblockpluschrome
comment:6 Changed 15 months ago by sebastian
- Milestone set to Adblock-Plus-3.4-for-Chrome-Opera-Firefox
- Resolution set to fixed
- Status changed from new to closed
comment:7 Changed 14 months ago by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Now working for both Chrome and Firefox on Windows. Thanks!
comment:8 Changed 9 months ago by takken3
Note: See
TracTickets for help on using
tickets.
Ross, this varies from the error you got last time. Can you try again, and let us know if you get the same error now, or which error you get instead (as of current master)?