Opened 13 months ago

Closed 12 months ago

Last modified 9 months ago

#6986 closed defect (fixed)

Running npm test fails on Windows for adblockpluscore

Reported by: geo Assignee: hfiguiere
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian, hfiguiere, tlucas Blocked By:
Blocking: #7116 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29891680/

Description

Environment

Windows 10
revision: git f2d0c16 hg e7abbf2e9d9b
nodejs: v8.11.3

How to reproduce

  1. Run npm install from PowerShell
  2. Run npm test from PowerShell

Observed behaviour

Some tests run, however we also have the following errors:

Failed running browser tests
TypeError: mode must be an integer
    at Object.fs.chmodSync (fs.js:1123:18)
    at startChromium (C:\Work\adblockpluschrome\adblockpluscore\test\runners\chromium_remote_process.js:62:6)
    at ensureChromium.then.chromiumPath (C:\Work\adblockpluschrome\adblockpluscore\test\runners\chromium_remote_process.js:194:17)
    at <anonymous>

and

FAILURES: Undone tests (or their setups/teardowns):
- testReadAndSaveToFile

To fix this, make sure all tests call test.done()
npm ERR! Test failed.  See above for more details.

Expected behaviour

The script should run without errors.

Change History (11)

comment:1 Changed 13 months ago by hfiguiere

  • Owner set to hfiguiere

fs.chmodSync expects an int, a constant has been passed as a parameter.

Last edited 13 months ago by hfiguiere (previous) (diff)

comment:2 Changed 13 months ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 13 months ago by hfiguiere

I don't have a Windows system handy. If you can test that patch, that would be very helpful.

comment:4 Changed 13 months ago by sebastian

For reference, we have a similar issue with the browser tests in adblockpluschrome which might have the same cause (unrelated of your suspicion), see #6985.

comment:5 Changed 13 months ago by mjethani

  • Component changed from Core to Automation

comment:6 Changed 13 months ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:7 Changed 12 months ago by hfiguiere

  • Blocking 7116 added

comment:8 Changed 12 months ago by hfiguiere

  • Cc tlucas added

comment:9 Changed 12 months ago by abpbot

A commit referencing this issue has landed:
Issue 6986 - Don't use chromium remote interface on Windows

comment:10 Changed 12 months ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 6986 - Don't use chromium remote interface on Windows

Note: See TracTickets for help on using tickets.