Opened 12 months ago

Closed 3 weeks ago

#6991 closed change (rejected)

Stop normalizing domain arguments in filter classes

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

In the isActiveOnDomain method of each ActiveFilter object, the parameter docDomain is lowercased and any trailing dots are removed. This is done for each filter. Most of the time, the caller either already has a lowercased domain with no trailing dot, or can do this transformation once on its own (calling isActiveOnDomain on each filter in a subscription, for example).

If this transformation is removed from the implementation of the function, it significantly improves the performance.

What to change

Remove the lowercasing and removal of any trailing dots from the implementation of isActiveOnDomain. Make sure callers are doing this on their own. Update the tests.

Change History (4)

comment:1 Changed 12 months ago by mjethani

  • Summary changed from Stop lowercasing and removing trailing dots in isActiveOnDomain to Stop lowercasing and removing trailing dots domain in filter classes

comment:2 Changed 12 months ago by mjethani

  • Summary changed from Stop lowercasing and removing trailing dots domain in filter classes to Stop normalizing domain arguments in filter classes

comment:3 Changed 12 months ago by mjethani

  • Ready unset

comment:4 Changed 3 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.