Changes between Version 14 and Version 18 of Ticket #6994


Ignore:
Timestamp:
10/23/2018 04:44:36 PM (12 months ago)
Author:
jsonesen
Comment:

Replying to mjethani:

Replying to mjethani:

if typeMask == 0 && RegExpFilter.prototype.contentType == 0, these filters should be skipped entirely

This is totally not what I meant. Could you please correct this?

For sure

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6994

    • Property Blocking changed from to 7000
  • Ticket #6994 – Description

    v14 v18  
    99 
    1010Change `_checkEntryMatch` in lib/matcher.js to initially loop through location only filters checking for matches using filter.regexp.test(location) or if a new location only version of `RegExpFilter.prototype.matches` is used it can call filter.matchesLocation. Additionally, in _checkEntryMatch, if  
    11 `typeMask == 0 && RegExpFilter.prototype.contentType == 0`, these filters should be skipped entirely. 
     11`typeMask & RegExpFilter.prototype.contentType == 0`, these filters should be skipped entirely. 
    1212 
    1313Add a isLocationOnly() property to the RegExpFilter class. Also, filters must not be stored twice so when adding to the fastFilterByKeyword map we should skip adding to the `matcher.filterByKeyword` map.