Opened 15 months ago
Closed 14 months ago
#6996 closed defect (fixed)
Mercurial 4.7 breaks use of revision number for `--change ` argument in hgreview.py
Reported by: | jsonesen | Assignee: | kvas |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Automation | Keywords: | |
Cc: | kvas, hfiguiere | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29897571 |
Description
Environment
Mecurial 4.7 Linux(Debian)
condingtools/hgreview.py (:tip)
How to reproduce
Upload change set using commit number passed to -c in hgreview
Observed behaviour
Stack trace returned
mercurial.error.ProgrammingError: unsupported changeid '945' of type <type 'str'>
Expected behaviour
Hg review should accept changeid with the change argument. Tried changing the parsing of the argument in hgreview.py to no avail, ended up reverting to mercurial 4.6 for the time being.
Change History (10)
comment:1 Changed 15 months ago by hfiguiere
comment:2 Changed 15 months ago by hfiguiere
- Cc hfiguiere added
comment:3 Changed 15 months ago by kvas
- Component changed from Unknown to Automation
- Owner set to kvas
- Review URL(s) modified (diff)
comment:4 Changed 15 months ago by kvas
- Status changed from new to reviewing
comment:5 Changed 14 months ago by abpbot
A commit referencing this issue has landed:
Issue 6996 - Fix -c option
comment:6 Changed 14 months ago by kvas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed 14 months ago by kvas
- Resolution fixed deleted
- Review URL(s) modified (diff)
- Status changed from closed to reopened
comment:8 Changed 14 months ago by kvas
- Status changed from reopened to reviewing
comment:9 Changed 14 months ago by abpbot
A commit referencing this issue has landed:
Fixes 6996 - Also fix -c when -t is not present
comment:10 Changed 14 months ago by kvas
- Resolution set to fixed
- Status changed from reviewing to closed
I noticed that too. I usually use -c . instead as a workaround (with the proper hg update prior to it.