Opened 8 months ago

Closed 8 months ago

Last modified 2 months ago

#6998 closed change (fixed)

Remove usage of Shadow DOM v0 from the content script

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, ukacar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29894561/

Description (last modified by mjethani)

Background

Shadow DOM v0 is deprecated and will be removed from Chrome in M73 (April 2019).

Since recent versions of both Chrome (see ticket:242#comment:58) and Firefox (see #5090) support user style sheets, and style sheets can be injected directly into the head element on older versions of Chrome and Firefox, as well as all versions of Edge (which does not support Shadow DOM v0 anyway), it is no longer necessary to use this feature.

What to change

Remove all code related to Shadow DOM v0 from the content script.

Hints for testers

Test that element hiding works on supported versions of Chrome both before and after (including) version 66 and those of Firefox both before and after (including) version 53. In other words, test all supported versions, but at least Chrome 65, Chrome 66, Firefox 52, and Firefox 53.

Given the following document:

<!DOCTYPE html>
<html>
  <body>
    <div class="ad">Ad</div>
  </body>
</html>

The filter ##.ad should hide the element that says "Ad".

On Chrome 66+ and Firefox 53+, the filter should also work for the following document (but is not expected to work on older versions of these browsers):

<!DOCTYPE html>
<html>
  <body>
    <div class="ad" style="display: block !important">Ad</div>
  </body>
</html>

Change History (10)

comment:1 Changed 8 months ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 8 months ago by abpbot

A commit referencing this issue has landed:
Issue 6998 - Stop using Shadow DOM v0

comment:3 follow-up: Changed 8 months ago by mjethani

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 8 months ago by mjethani

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:5 Changed 8 months ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:6 in reply to: ↑ 3 Changed 3 months ago by ukacar

Replying to mjethani:is there anything for us to test regarding this change? :)

comment:7 Changed 3 months ago by mjethani

  • Description modified (diff)

comment:8 Changed 3 months ago by mjethani

  • Cc ukacar added

comment:9 Changed 3 months ago by mjethani

@ukacar sorry about this, I have updated the ticket with some more information.

Last edited 3 months ago by mjethani (previous) (diff)

comment:10 Changed 2 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.