Opened 5 years ago

Closed 5 years ago

Last modified 8 months ago

#7 closed change (fixed)

[meta] libadblockplus integration cleanup

Reported by: fhd Assignee: rjeschke
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords: meta
Cc: Blocked By: #8, #9, #10, #11, #12, #15, #16, #17, #18, #19, #20, #21, #22, #23, #24, #25, #26, #27, #28, #29, #30, #31, #32, #33, #34, #35, #36, #37, #38, #39, #282
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by fhd)

Background

The libadblockplus integration review was huge, and we decided to create follow-ups for anything non-critical.

What to change

Fix all these issues:

Ticket Status Resolution Summary Owner
#8 closed fixed [libadblockplus integration cleanup] Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild fhd
#9 closed fixed [libadblockplus integration cleanup] Catch exceptions consistently fhd
#10 closed fixed [libadblockplus integration cleanup] Consider the encoding fhd
#11 closed fixed [libadblockplus integration cleanup] Don't lower-case the header value fhd
#12 closed fixed [libadblockplus integration cleanup] Translate Java network errors properly fhd
#15 closed fixed [libadblockplus integration cleanup] Store the exception message in JavaException rather than extracting it when an exception occurs fhd
#17 closed fixed [libadblockplus integration cleanup] Don't hard code the JNI version
#18 closed incomplete [libadblockplus integration cleanup] Use shared pointers for the platform-specific implementations
#19 closed fixed [libadblockplus integration cleanup] Initialise path variable closer to its use fhd
#20 closed fixed [libadblockplus integration cleanup] Don't use std::bind for UpdateAvailableCallback, it's redundant
#21 closed fixed [libadblockplus integration cleanup] Don't manually clean up callbacks
#22 closed fixed [libadblockplus integration cleanup] Don't call IsListed(), it's redundant
#23 closed fixed [libadblockplus integration cleanup] Rename "actualize" function
#24 closed fixed [libadblockplus integration cleanup] Use Matcher.find() instead of Matcher.matches()
#25 closed fixed [libadblockplus integration cleanup] Rename globalJvm parameter
#26 closed fixed [libadblockplus integration cleanup] Reduce exception handling code duplication
#27 closed fixed [libadblockplus integration cleanup] Remove unnecessary DeleteLocalRef()
#28 closed fixed [libadblockplus integration cleanup] Simplify counting loop
#29 closed fixed [libadblockplus integration cleanup] Create RAII wrapper for JNIEnv
#30 closed fixed [libadblockplus integration cleanup] Remove unused variable
#31 closed fixed [libadblockplus integration cleanup] Move GetString to the JString helper class
#32 closed fixed [libadblockplus integration cleanup] Clean up build files rjeschke
#33 closed fixed [libadblockplus integration cleanup] Use a smart pointer for the filter engine
#34 closed fixed [libadblockplus integration cleanup] Remove misleading const
#35 closed incomplete [libadblockplus integration cleanup] abpEngine.cpp needs various things cleaned up rjeschke
#36 closed fixed [libadblockplus integration cleanup] Name source files consistently with libadblockplus (upper camel case) rjeschke
#37 closed fixed [libadblockplus integration cleanup] Refactor JNI method registration to use 'registerNatives'
#38 closed fixed [libadblockplus integration cleanup] Refactor away global variable declarations in ApbEngine.cpp
#39 closed fixed [libadblockplus integration cleanup] Remove unused Java class files
#282 closed fixed [libadblockplus integration cleanup] Use Utils.getDocLink() instead of duplicating the functionality


Change History (28)

comment:1 Changed 5 years ago by philll

  • Blocked By 8 added

comment:2 Changed 5 years ago by philll

  • Description modified (diff)

comment:3 Changed 5 years ago by philll

  • Description modified (diff)

comment:4 Changed 5 years ago by philll

  • Blocked By 9 added

comment:5 Changed 5 years ago by philll

  • Blocked By 10 added

comment:6 Changed 5 years ago by philll

  • Blocked By 11 added

comment:7 Changed 5 years ago by philll

  • Blocked By 12 added

comment:8 Changed 5 years ago by philll

  • Description modified (diff)

comment:9 Changed 5 years ago by philll

  • Blocked By 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39 added

comment:10 Changed 5 years ago by philll

  • Component changed from Libadblockplus to ABP-Android

comment:11 Changed 5 years ago by philll

  • Description modified (diff)

comment:12 Changed 5 years ago by trev

  • Description modified (diff)

comment:13 Changed 5 years ago by philll

  • Keywords libadblockplus integration cleanup removed

comment:14 Changed 5 years ago by trev

  • Keywords meta added
  • Summary changed from libadblockplus integration cleanup to [meta] libadblockplus integration cleanup

comment:15 Changed 5 years ago by philll

  • Owner set to rjeschke
  • Status changed from new to assigned

comment:16 Changed 5 years ago by fhd

  • Reporter changed from philll to trev

comment:17 Changed 5 years ago by fhd

  • Reporter changed from trev to fhd

comment:18 Changed 5 years ago by fhd

  • Description modified (diff)

comment:19 Changed 5 years ago by fhd

  • Priority changed from Unknown to P3

comment:20 Changed 5 years ago by fhd

  • Blocked By 282 added
  • Ready unset

comment:21 Changed 5 years ago by philll

  • Status changed from assigned to new

The assigned state will be dropped by #403

comment:22 Changed 5 years ago by rjeschke

  • Blocked By 13 removed

comment:23 Changed 5 years ago by rjeschke

  • Blocked By 14 removed

comment:24 Changed 5 years ago by philll

@rjeschke: The issue looks pretty complete to me. If you agree, please set it to "ready"

comment:25 Changed 5 years ago by rjeschke

@philll: Let me have a look at the last 4 open issues (today/tomorrow), then we can close this issue.

comment:26 Changed 5 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from new to closed

comment:27 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Android-1.3
  • Platform set to Android
Note: See TracTickets for help on using tickets.