Changes between Version 1 and Version 2 of Ticket #7004


Ignore:
Timestamp:
10/06/2018 09:29:46 AM (10 months ago)
Author:
tlucas
Comment:

From IRC:

1:09 PM <snoack> I tried around a bit myself, and the best I could come up with is `git rev-list --count --branches --tags <rev>`. The number is still somewhat higher than with Mercurial, but well, if we never go back to Mercurial, that shouldn't cause any issues.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7004

    • Property Owner set to tlucas
    • Property Priority changed from Unknown to P3
    • Property Ready set
  • Ticket #7004 – Description

    v1 v2  
    99 
    1010=== Expected behaviour === 
    11 The build numbers should match 
     11The build numbers should match OR the build numbers generated from git should be higher (to avoid rejection of lower versions, once we start building / distributing from a git environment). 
    1212 
    1313=== Hint === 
    1414 
    1515The responsible code is [https://hg.adblockplus.org/buildtools/file/tip/packager.py#l68 here] 
    16  
    17 See the discussion in the [http://hub.eyeo.com/issues/12963 hub] 
    18 While we seem to want the number that would be generated by mercurial, git is not capable (to our current knowledge) to reliably reproduce that number. 
    19  
    20 An alternative could be parsing "changeset \d+" from "https://hg.adblockplus.org/adblockpluschrome/rev/master". 
     16Git is not capable (to our current knowledge) of reliably reproducing the revision number yielded by Mercurial.