Changes between Initial Version and Version 3 of Ticket #700


Ignore:
Timestamp:
06/24/2014 09:07:46 AM (5 years ago)
Author:
sebastian
Comment:

Currently only filters based on the elements URL, CSS classes or ID can be generated. However, generating a filter based on the elements name and all of its attributes might be a good fallback, in case everything else fails.

Also the overlay on the given website would cover the "Block Element" dialog, because it is using a higher z-index. Instead hard-coding a z-index, a more robust approach would be to set the z-index dynamically to make sure that it is the highest in the document.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #700

    • Property Cc sebastian removed
    • Property Owner set to sebastian
    • Property Status changed from new to reviewing
    • Property Summary changed from block element ABP for chrome 1.8.3 does not work to block element doesn't work for elements that don't have a "src", "id" or "class" attribute and the dialog is covered by other elements on some websites
  • Ticket #700 – Review URL(s)

    initial v3  
     1http://codereview.adblockplus.org/4829486721794048 
     2http://codereview.adblockplus.org/5474511327592448