Opened 5 years ago

Closed 4 years ago

#701 closed defect (fixed)

firefox' issue reporter openes report URL instead of showing context menu when right-clicking

Reported by: philll Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29322658/

Description (last modified by trev)

Environment

Firefox ESR 24.5
ABP 2.6.3.3836

How to reproduce

  1. Open any website
  2. Click the ABP icon
  3. Click "Report issue on this page"
  4. Select "Adblock Plus does not block..."
  5. Click the "Next" button
  6. Click the "Send report" button
  7. Right click the URL of the report

Observed behaviour

The report is opened in a new tab.

Expected behaviour

The click should be ignored.

Change History (6)

comment:1 Changed 5 years ago by philll

  • Priority changed from Unknown to P3

comment:2 Changed 5 years ago by saroyanm

  • Platform set to Unknown

I think we will need to create our own context menu for that purpose.
Not sure if we can use the context menu that Firefox using in it's web content.

comment:3 Changed 5 years ago by philll

  • Platform changed from Unknown to Firefox

comment:4 Changed 4 years ago by trev

  • Owner set to trev
  • Tester set to Unknown

comment:5 Changed 4 years ago by trev

  • Description modified (diff)
  • Review URL(s) modified (diff)

I think that displaying a context menu would go too far, we should simply ignore middle- and right-clicks - we already do it like that for the list of previously submitted reports.

Last edited 4 years ago by trev (previous) (diff)

comment:6 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.