Opened 16 months ago

Closed 16 months ago

Last modified 15 months ago

#7013 closed defect (fixed)

Firefox error: this.created() is not defined

Reported by: agiammarchi Assignee:
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #7014 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/143

Description (last modified by saroyanm)

Background

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/213

Note

There are currently errors in non native Custom Elements implementation of the this.created() callback, which was a dirty invoke from the attributeChangedCallback method, since it's meant to be used only once as constructor.

Change History (5)

comment:1 Changed 16 months ago by saroyanm

  • Component changed from Unknown to User-Interface
  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

Updated the description to reflect actual issue it's fixing.

Last edited 16 months ago by saroyanm (previous) (diff)

comment:2 Changed 16 months ago by saroyanm

  • Blocking 7014 added

comment:3 Changed 16 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from new to closed

This one is also fixed

comment:4 Changed 16 months ago by abpbot

A commit referencing this issue has landed:
Issue 7013 - this.created() is not defined

comment:5 Changed 15 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Issue reporter looks to be working as expected in all browsers.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.