Opened 9 months ago

Closed 9 months ago

Last modified 8 months ago

#7014 closed change (fixed)

Update adblockplusui dependency to hg:42849c775697 (release-2018-4.3)

Reported by: saroyanm Assignee:
Priority: P2 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: wspee, sebastian, kzar, agiammarchi, greiner Blocked By: #7013, #7017, #7018
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29902563/

Description (last modified by saroyanm)

Background

There were some regressions noticed, some of them are crutial(ex.: Issue reporter being broken on Firefox) that we would like to have in the ABP 3.4 release if possible:


Also: Some FRP translations were gone after updating the source strings.

What to change

Change adblockplusui dependency to hg:42849c775697 git:1106767

Hints for testers

Most of the issue are fixed for the Firefox, but it probably make sense to test in various environments to ensure they don't appear there as well ex. in Edge.

  • Ensure that issue reporter doesn't stuck and no error is thrown(UI#213).
  • Ensure that popup closes when making the actions specified below(UI#215):
    • When clicking on "Report issue"
    • When clicking on the gear icon
    • When clicking on "Refresh"
    • Selecting an element on the page after clicking on "Block element"
    • Clicking on Promotional links next to "Interested in Adblock Plus on mobile?"
  • When reporting the issue ensure that the data in the dialog when clicking "Click this link to review the report data before sending" is shown structured rather than on one line(UI#214).

Change History (23)

comment:1 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:2 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:3 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:4 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:5 Changed 9 months ago by saroyanm

  • Summary changed from Update adblockplusui dependency to TBD to Update adblockplusui dependency to TBD (release-2018-4.3)

comment:6 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:7 Changed 9 months ago by saroyanm

  • Blocked By 7013 added

comment:8 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:9 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:10 Changed 9 months ago by saroyanm

  • Cc wspee sebastian kzar agiammarchi greiner added

@Sebastian, @kzar - there were some regressions noticed on the Firefox, 1 is fixed another one is about to fix, just a detail comment, also there are some missing translation we would like to include in ABP v3.4, please let us know if you think it's feasible to squeeze this changes into the ABP v3.4 release. Thanks in advance.

comment:11 Changed 9 months ago by sebastian

  • Milestone set to Adblock-Plus-3.4-for-Chrome-Opera-Firefox
  • Priority changed from Unknown to P2
  • Ready set

comment:12 Changed 9 months ago by saroyanm

  • Component changed from Unknown to Platform

Update the module, thanks Sebastian.

comment:13 Changed 9 months ago by saroyanm

  • Blocked By 7017 added

comment:14 Changed 9 months ago by saroyanm

  • Blocked By 7018 added

comment:15 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:16 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:17 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:18 Changed 9 months ago by saroyanm

  • Description modified (diff)

comment:19 Changed 9 months ago by saroyanm

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to TBD (release-2018-4.3) to Update adblockplusui dependency to hg:42849c775697 (release-2018-4.3)

comment:20 Changed 9 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:21 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 7014 - Update adblockplusui dependency to hg:42849c775697

comment:22 Changed 9 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:23 Changed 8 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Issues listed above are fixed. Issue reporter works as expected. Popup closes as expected. FRP does not look to be missing any strings.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.