Opened on 10/04/2018 at 02:15:18 PM

Closed on 11/14/2018 at 04:15:46 PM

#7019 closed change (fixed)

[CMS] Refactor ``

Reported by: atudor Assignee: atudor
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: kvas, jsonesen Blocked By:
Blocking: #6337 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by atudor)


The days of CMS are coming to an end. Slowly, but steadily, it's starting to change shape. Now it's's time to be refactored :D.

What to change

Refactor The key targets when refactoring this code are:

  1. Making it PEP8 compliant. There are a couple of flake8 exceptions that are added for the current implementation and which can be easily be handled: A101, A107, A302, E501, F401
  2. Make the code more easily readable. The most important thing here is adding docstrings to all the functions involved.
  3. Increase test coverage from 69%.

Where possible, some performance enhancements will be included as well.

Attachments (0)

Change History (6)

comment:1 Changed on 10/05/2018 at 12:54:56 PM by atudor

  • Description modified (diff)

comment:2 Changed on 10/14/2018 at 11:36:58 AM by atudor

  • Description modified (diff)

comment:3 Changed on 10/16/2018 at 12:01:11 PM by atudor

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 10/25/2018 at 03:40:39 PM by jsonesen

  • Cc jsonesen added

comment:5 Changed on 10/29/2018 at 11:12:27 AM by abpbot

A commit referencing this issue has landed:
Issue 7019 - Refactor

comment:6 Changed on 11/14/2018 at 04:15:46 PM by atudor

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from atudor.
Note: See TracTickets for help on using tickets.