Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#7020 closed change (fixed)

[Gitlab CI] Sign Adblock Plus for Firefox development builds via a Node.js script

Reported by: tlucas Assignee: tlucas
Priority: P2 Milestone:
Module: Automation Keywords: gitlab, ci
Cc: sebastian, kzar Blocked By: #6682
Blocking: #7055 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29901591/

Description (last modified by tlucas)

Background

In #6651, we introduced CI for adblockpluschrome with gitlab-ci. This enables us to implement a first approach for CD for Adblock Plus, which is also part of Priority Experiment 3.

In #6682, we started creating unsigned packages through GitLab CI/CD. Continuing with our efforts, we now want to have Adblock Plus for Firefox development builds signed and deployed through GitLab CI/CD.

What to change

Add an npm script

$ npm run publish -- gecko
  -p/--package <path_to_unsigned_package>
  -c/--credentials <path_to_oauth_credentials>
  -t/--target-folder <output_directory>

which let's AMO sign the unsigned package via ​sign-addon and copies the resulting signed package to <output_directory.

Change History (9)

comment:1 Changed 2 years ago by tlucas

  • Priority changed from P1 to P2

comment:2 Changed 2 years ago by tlucas

  • Description modified (diff)

comment:3 Changed 2 years ago by tlucas

  • Description modified (diff)

comment:4 Changed 2 years ago by tlucas

  • Description modified (diff)
  • Owner set to tlucas

comment:5 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
​Issue 7020 - publish gecko with Node.js

comment:6 Changed 2 years ago by tlucas

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 2 years ago by tlucas

  • Review URL(s) modified (diff)

comment:8 Changed 2 years ago by tlucas

  • Blocking 7055 added

comment:9 Changed 2 years ago by tlucas

  • Summary changed from [Gitlab CI] Invoke build / deploy in GitLab CI/CD to [Gitlab CI] Sign Adblock Plus for Firefox development builds via a Node.js script
Note: See TracTickets for help on using tickets.