Opened 13 days ago

Last modified 4 days ago

#7027 reviewing change

Adapt code to work with latest changes to FilterStorage.subscriptions

Reported by: greiner Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #7054 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29907592/
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/150
https://gitlab.com/eyeo/adblockplus/abpui/adblockpluschrome/merge_requests/10

Description (last modified by greiner)

Background

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/219

What to change

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/219

Hints for testers

  • Adding filters through Block element dialog should not fail.
  • Saving custom filters in desktop options page should add filters the user entered and remove filters the user deleted from the text area.
  • Filter lists should be correctly displayed in desktop options page, mobile options page and issue report data.
  • Disabled filters within filter should should be listed in the issue report using the "disabledFilters" property in the issue report data.

Change History (6)

comment:1 Changed 13 days ago by greiner

  • Owner set to greiner

comment:2 Changed 13 days ago by greiner

  • Description modified (diff)

Added hints for testers.

comment:3 Changed 13 days ago by greiner

  • Description modified (diff)

comment:4 Changed 9 days ago by jsonesen

  • Review URL(s) modified (diff)

comment:5 Changed 4 days ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 4 days ago by greiner

  • Blocking 7054 added
Note: See TracTickets for help on using tickets.