Opened on 10/08/2018 at 06:05:36 PM

Closed on 11/20/2018 at 01:20:09 PM

Last modified on 02/14/2019 at 03:24:30 PM

#7027 closed change (fixed)

Adapt code to work with latest changes to FilterStorage.subscriptions

Reported by: greiner Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #7054 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by greiner)



What to change


Hints for testers

  • Adding filters through Block element dialog should not fail.
  • Saving custom filters in desktop options page should add filters the user entered and remove filters the user deleted from the text area.
  • Filter lists should be correctly displayed in desktop options page, mobile options page and issue report data.
  • Disabled filters within filter should should be listed in the issue report using the "disabledFilters" property in the issue report data.

Attachments (0)

Change History (14)

comment:1 Changed on 10/08/2018 at 06:07:32 PM by greiner

  • Owner set to greiner

comment:2 Changed on 10/08/2018 at 06:20:05 PM by greiner

  • Description modified (diff)

Added hints for testers.

comment:3 Changed on 10/08/2018 at 06:22:43 PM by greiner

  • Description modified (diff)

comment:4 Changed on 10/12/2018 at 05:06:31 AM by jsonesen

  • Review URL(s) modified (diff)

comment:5 Changed on 10/17/2018 at 08:40:33 AM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 10/17/2018 at 08:42:49 AM by greiner

  • Blocking 7054 added

comment:8 Changed on 10/22/2018 at 08:00:52 AM by abpbot

comment:9 Changed on 10/22/2018 at 07:17:08 PM by jsonesen

What do you think about reopening and using this ticket for the abpchrome repo as well? There is already a review:

Oops meant to comment on the other ticket that this one is blocking. My badddd

Last edited on 10/23/2018 at 02:09:55 AM by jsonesen

comment:10 Changed on 10/25/2018 at 10:45:49 AM by abpbot

comment:11 Changed on 10/25/2018 at 10:55:06 AM by greiner

  • Resolution fixed deleted
  • Status changed from closed to reopened

This change prematurely landed in the Mercurial master so I backed it out to allow for further fixes that need to be included in the ongoing 3.4 extension release. As soon as that one's done, we can reapply the changes.

comment:12 Changed on 11/20/2018 at 01:19:37 PM by abpbot

comment:13 Changed on 11/20/2018 at 01:20:09 PM by greiner

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:14 Changed on 02/14/2019 at 03:24:30 PM by ukacar

  • Verified working set

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Note: See TracTickets for help on using tickets.