Opened 2 years ago

Closed 23 months ago

Last modified 20 months ago

#7027 closed change (fixed)

Adapt code to work with latest changes to FilterStorage.subscriptions

Reported by: greiner Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #7054 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by greiner)



What to change


Hints for testers

  • Adding filters through Block element dialog should not fail.
  • Saving custom filters in desktop options page should add filters the user entered and remove filters the user deleted from the text area.
  • Filter lists should be correctly displayed in desktop options page, mobile options page and issue report data.
  • Disabled filters within filter should should be listed in the issue report using the "disabledFilters" property in the issue report data.

Change History (14)

comment:1 Changed 2 years ago by greiner

  • Owner set to greiner

comment:2 Changed 2 years ago by greiner

  • Description modified (diff)

Added hints for testers.

comment:3 Changed 2 years ago by greiner

  • Description modified (diff)

comment:4 Changed 2 years ago by jsonesen

  • Review URL(s) modified (diff)

comment:5 Changed 2 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by greiner

  • Blocking 7054 added

comment:9 Changed 2 years ago by jsonesen

What do you think about reopening and using this ticket for the abpchrome repo as well? There is already a review:

Version 0, edited 2 years ago by jsonesen (next)

comment:11 Changed 2 years ago by greiner

  • Resolution fixed deleted
  • Status changed from closed to reopened

This change prematurely landed in the Mercurial master so I backed it out to allow for further fixes that need to be included in the ongoing 3.4 extension release. As soon as that one's done, we can reapply the changes.

comment:13 Changed 23 months ago by greiner

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:14 Changed 20 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.