Changes between Initial Version and Version 1 of Ticket #7033, comment 14


Ignore:
Timestamp:
10/17/2018 03:38:56 PM (18 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7033, comment 14

    initial v1  
    22> The exact behavior chosen in #6923, after much discussion, was inspired by the requirements in #6920, which in turn was a result of the work in #6685 (incremental filter list downloads). We would have to reopen that discussion if it is infeasible for filter lists to update their templates in time in response to this change. 
    33 
    4 I forgot to include #6950. There were two parts to the change in #6923, the second part was the result of changes for #6950 in python-abp. I can't really tell where the discussion happened to take it from "any non-empty comment" to "any line that doesn't parse as metadata". 
     4I forgot to include #6950. There were two parts to the change in #6923, the second part was the result of changes for #6950 in python-abp. I can't really tell where the discussion happened to take it from "any non-empty comment" to "any line that parses as metadata". 
    55 
    66Anyway, the regular expression in the first patch was `/^\s*!\s*(?:(\w+)\s*:\s*(.*)|\S)/`. The second patch changed it to `/^\s*!\s*(.*?)\s*:\s*(.*)/`. We could just change it to `/^\s*!\s*(?:(.*?)\s*:\s*(.*))?/` now to allow even blank comments.