Opened 5 years ago

Closed 5 years ago

#704 closed change (fixed)

Generate protocol-agnostic filters by "Block element" on Chrome

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.8.6-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: mapx Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5132310882025472

Description

Background

You can select "Block element" in the bubble and click on an element on the web page in order to generate a filter on Chrome, Opera and Safari. However unlike with Element Hiding Helper, generated request blocking filters include the protocol instead using ||.

What to change

Replace the protocol part of the URL in request blocking filters generated by block element with ||, in order to match any protocol.

Change History (4)

comment:1 Changed 5 years ago by mapx

  • Cc mapx added

comment:2 Changed 5 years ago by sebastian

  • Ready set

comment:3 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Platform set to Unknown
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.