Changes between Version 8 and Version 10 of Ticket #7043


Ignore:
Timestamp:
10/15/2018 11:36:29 PM (20 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7043

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to fixed
  • Ticket #7043 – Description

    v8 v10  
    66=== What to change === 
    77In `lib/filterClasses.js` reject blank CSPs only if it is a blocking filter, not if it is whitelist filter. 
     8 
     9=== Hints for testers === 
     10Make sure that the behavior expected in #6871 still works for blocking filters. 
     11 
     12For whitelist filters, after this change, the `$csp` option should be able to have a blank value. In order to verify this, write two filters `||example.com^$csp=script-src 'none'` and `@@||example.com^$csp` and see that inline scripts are still allowed on the page. You could use the following HTML to test this: 
     13 
     14{{{ 
     15<!DOCTYPE html> 
     16<h1>Test</h1> 
     17<script> 
     18  console.log("Hello from inline script"); 
     19</script> 
     20}}} 
     21 
     22If the second filter is being accepted as valid, then the page should print `Hello from inline script` to the console. Also verify that removing the second filter then prevents the inline script from executing.