Changes between Initial Version and Version 6 of Ticket #7043


Ignore:
Timestamp:
10/15/2018 08:34:36 PM (2 years ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7043

    • Property Cc kzar amrmak added
    • Property Priority changed from P2 to P1
  • Ticket #7043 – Description

    initial v6  
    11=== Background === 
    2 In #6871 we stopped accepting filters with blank CSPs. But there are [https://github.com/abp-filters/abp-filters-anti-cv/blob/4d3f39a701fdf7730e5b95c9b2d126b48e448573/english.txt#L3 such filters in the anti-circumvention list], they just happen to be whitelist filters. In the current version of Adblock Plus these filters are being considered invalid because of the change for #6871. 
     2In #6871 we stopped accepting filters with blank CSPs. But there are [https://github.com/abp-filters/abp-filters-anti-cv/blob/4d3f39a701fdf7730e5b95c9b2d126b48e448573/english.txt#L3 such filters in the anti-circumvention list], they just happen to be whitelist filters. In the current ~~version~~ [https://adblockplus.org/en/development-builds development build] of Adblock Plus these filters are being considered invalid because of the change for #6871. 
    33 
    44It makes sense to allow blank CSPs in whitelist filters, because the value itself has no meaning (the fact that the filter matches the URL and has the `$csp` option is enough for whitelisting the URL).