Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#7053 closed change (fixed)

[Gitlab CI] [Firefox] Create meta files for Adblock Plus for Firefox development builds

Reported by: tlucas Assignee: tlucas
Priority: P2 Milestone: Adblock-Plus-3.4.1-for-Chrome-Opera-Firefox
Module: Automation Keywords: gitlab, ci
Cc: sebastian, kzar Blocked By:
Blocking: #7055 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/7

Description (last modified by tlucas)

Background

With #7020, we started signing packages for Adblock Plus for Firefox development builds with Node.js. To fully publish those builds, we also need to provide an updates.json, where Firefox clients can check for new versions, as well as a list of previous devevlopment builds, which is currently available here

What to change

Relying on --target from the command introduced in #7020 pointing to a folder, where all previous development builds exist, implement the following:

Let npm run publish -- gecko ...

  • remove retired development builds from the --target folder (currently, we keep a maximum of 150 builds)
  • create a symlink called 00latest.xpi, linking to the most recent development build
  • render a index.html. which lists all currently available development builds, as seen here

A hint: this functionality is currently available in abpssembly's NightlyBuild.

Change History (7)

comment:1 Changed 11 months ago by tlucas

  • Blocking 7055 added

comment:2 Changed 11 months ago by tlucas

  • Owner set to tlucas
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 11 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 11 months ago by tlucas

  • Description modified (diff)

comment:5 Changed 11 months ago by abpbot

A commit referencing this issue has landed:
Issue 7053 - Create meta files for Firefox builds

comment:6 Changed 11 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 11 months ago by wspee

  • Milestone set to Adblock-Plus-3.4.1-for-Chrome-Opera-Firefox

Since this is already in master I'll assume it's fine to include in Adblock-Plus-3.4.1-for-Chrome-Opera-Firefox, please let me know if this should be backed-out instead.

Note: See TracTickets for help on using tickets.