Opened 7 months ago

Closed 7 months ago

#7059 closed change (fixed)

Modify fldiff so it can handle multiple files

Reported by: rhowell Assignee: rhowell
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29922555

Description (last modified by rhowell)

Background

fldiff was introduced in 6945 to generate diffs between two filter lists. It currently accepts as input the old filter list and the latest filter list, finds their diff, and publishes it to the specified outfile (if any). After talking with the infrastructure team, we decided it would be better if fldiff would accept a list of all the filter list archives (Eg. the last 48 versions), and publish each of their diffs to the latest version.

What to change

Change fldiff so it accepts as input an (optional) output directory, the filename of the latest filter list, and the filenames of all the archived filter lists to create diffs for. For each archived filter list, get the diff between it and the latest list, and replace the old diff with the new one.

Change History (4)

comment:1 Changed 7 months ago by rhowell

  • Owner set to rhowell
  • Review URL(s) modified (diff)

comment:2 Changed 7 months ago by rhowell

  • Description modified (diff)

comment:3 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 7059 - Modify fldiff so it can handle multiple files

comment:4 Changed 7 months ago by rhowell

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.