Opened 7 months ago

Last modified 6 months ago

#7064 reviewing change

[CMS] Add requirements.txt

Reported by: atudor Assignee: atudor
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29942562/

Description

Background

Currently, we have four 3rd party libraries that are used in CMS:

  1. requests - used in the XTM integration.
  2. urllib3 - prerequisite for requests.
  3. jinja2 - used to parse templates.
  4. werkzeug (optional) - can be used to run the test server. Offers some extra debugging information, compared to the built-in libraries.

This way, we can also avoid library-related issues, such as the one from #7057, can be easily fixed to avoid production issues.

What to change

  1. Create a file requirements.txt
  2. Add the libraries above to the file
  3. Document the use of this in README.md

Change History (2)

comment:1 Changed 7 months ago by kvas

  • Component changed from Unknown to Sitescripts
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 6 months ago by atudor

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.