Changes between Version 53 and Version 54 of Ticket #7065


Ignore:
Timestamp:
11/23/2018 02:28:43 PM (12 months ago)
Author:
kzar
Comment:

I artificially created an infinite loop in the frame structure and saw symptoms in line with what you have all reported. (That doesn't prove anything, but is a good sign at least.)

I have suspicions about the code that's to blame, and a potential fix/workaround. Any chance someone here could test an experimental build for me, to see if the problem goes away?

If you'd like to test it for me, here are the steps:

  1. Download the adblockpluschrome-waiting-test.zip attachment I'm about to upload.
  2. Extract it somewhere.
  3. Open the Chrome extensions page chrome://extensions/.
  4. Ensure that all copies of Adblock Plus are disabled / removed.
  5. Click the "Developer mode" toggle on the top right of the page.
  6. Click "Load unpacked"
  7. Select the directory where you extracted the .zip file.
  8. Test to see if the "Waiting for Extension Adblock Plus..." message is still a problem.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7065

    • Property Status changed from new to reviewing
  • Ticket #7065 – Description

    v53 v54  
    1616=== Notes === 
    1717- It seems that `checkWhitelisted` is getting stuck in an infinite loop, with the frame having the parentFrame of itself. 
     18- I suspect this is related to [https://hg.adblockplus.org/adblockpluschrome/rev/c8ab89541a9c my c8ab89541a9c change] for #6808, in combination with a Chromium bug. I have not been able to verify that however, since I so far have been unable to reproduce the problem. 
  • Ticket #7065 – Review URL(s)

    v53 v54  
     1https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/18