Changes between Version 54 and Version 69 of Ticket #7065


Ignore:
Timestamp:
11/26/2018 02:17:29 PM (12 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7065

    • Property Cc BrentM Ross added
    • Property Priority changed from P2 to P1
    • Property Milestone changed from to Adblock-Plus-3.4.2-for-Chrome-Opera-Firefox
  • Ticket #7065 – Description

    v54 v69  
    1717- It seems that `checkWhitelisted` is getting stuck in an infinite loop, with the frame having the parentFrame of itself. 
    1818- I suspect this is related to [https://hg.adblockplus.org/adblockpluschrome/rev/c8ab89541a9c my c8ab89541a9c change] for #6808, in combination with a Chromium bug. I have not been able to verify that however, since I so far have been unable to reproduce the problem. 
     19 
     20=== Hints for testers === 
     21Since this issue is very hard to reproduce, you might not be able to verify it's fixed. But, since I did touch the page/frame logic I recommend testing things like blocking, the various types of whitelisting and element hiding. Keep a look out for problems where a site should be whitelisted but things are still blocked, and similar. Please test on old and new versions of both Chrome and Firefox.