#7077 closed defect (fixed)

Critical notification animation does not stop when dismissed

Reported by: Ross Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, greiner, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/10

Description (last modified by kzar)

Environment

Adblock Plus 3.3.2.2176 (also 3.3.2)
Chrome 70 / Chrome 49 / Windows 10

How to reproduce

  1. Trigger a critical notification, for example by appending this snippet to the end of adblockpluschrome/lib/notificationHelper.js and browsing to https://example.com:
require("notification").Notification.addNotification({
  id: new Date() | 0,
  type: "critical",
  title: "Notification title",
  message: "<a>Open contribution page</a>",
  links: ["contribute"],
  urlFilters: ["||example.com^$document"]
});

Observed behaviour

The critical notification is displayed. However if the notification is dismissed via the desktop notification (instead of via the popup), the ! icon animation continues to play.

Expected behaviour

The ! animation to be stopped when the notification is dismissed.

Hints for testers

This change tweaks the logic which handles what happens when the desktop notification is clicked (either on a button, or elsewhere) or closed. Therefore, it's important to test that things work correctly there, for various different types of notifications, on different supported browsers, and on different operating systems which handle notifications differently.

Change History (5)

comment:1 Changed 12 months ago by Ross

  • Summary changed from Critical notification to Critical notification animation does not stop when dismissed

comment:2 Changed 12 months ago by kzar

  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

I can also reproduce this with Chrome 70 on Linux. Investigating now, but I don't think this should block the upcoming release.

comment:3 Changed 12 months ago by kzar

  • Owner set to kzar
  • Review URL(s) modified (diff)

comment:4 Changed 12 months ago by kzar

  • Status changed from new to reviewing

comment:5 Changed 12 months ago by kzar

  • Cc Ross added
  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

A commit (incorrectly!) referencing this issue has landed:
Issue 7707 - Stop icon animation after notification is clicked

Note: See TracTickets for help on using tickets.