#7079 closed change (fixed)

Update buildtools dependency to 29aa8a195b8e

Reported by: tlucas Assignee: tlucas
Priority: P3 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, geo Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/11

Description (last modified by tlucas)

Background

The introduction of ManifoldJS in #6291 introduced a regression, by reverting the first patches for #5666 / #5668.

This dependency updates reintroduces them.

Included changes in buildtools

The list of changes imported by this is:


https://hg.adblockplus.org/buildtools/rev/adada3ae13be Noissue - Add peer dependency "acorn" Tristan Lucas

What to change

Update the buildtools dependency to:

mercurial git
29aa8a195b8e e018864

Hints for testers

The build itself should not be changed, besides the altered version numbers (see #5666 / #5668)

Change History (6)

comment:1 Changed 13 months ago by tlucas

  • Owner set to tlucas

comment:2 Changed 13 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 13 months ago by tlucas

  • Description modified (diff)

comment:4 Changed 13 months ago by abpbot

A commit referencing this issue has landed:
Issue 7079 - Update buildtools to 29aa8a195b8e / e018864

comment:5 Changed 13 months ago by sebastian

  • Milestone set to Adblock-Plus-3.4-for-Chrome-Opera-Firefox

comment:6 Changed 13 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.