Opened on 10/30/2018 at 06:15:08 PM

Closed on 11/13/2018 at 11:36:06 AM

#7079 closed change (fixed)

Update buildtools dependency to 29aa8a195b8e

Reported by: tlucas Assignee: tlucas
Priority: P3 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, geo Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by tlucas)


The introduction of ManifoldJS in #6291 introduced a regression, by reverting the first patches for #5666 / #5668.

This dependency updates reintroduces them.

Included changes in buildtools

The list of changes imported by this is: Noissue - Add peer dependency "acorn" Tristan Lucas

What to change

Update the buildtools dependency to:

mercurial git
29aa8a195b8e e018864

Hints for testers

The build itself should not be changed, besides the altered version numbers (see #5666 / #5668)

Attachments (0)

Change History (6)

comment:1 Changed on 10/30/2018 at 06:17:09 PM by tlucas

  • Owner set to tlucas

comment:2 Changed on 10/30/2018 at 06:18:55 PM by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 10/30/2018 at 06:20:17 PM by tlucas

  • Description modified (diff)

comment:4 Changed on 10/30/2018 at 06:22:22 PM by abpbot

A commit referencing this issue has landed:
Issue 7079 - Update buildtools to 29aa8a195b8e / e018864

comment:5 Changed on 10/30/2018 at 06:24:12 PM by sebastian

  • Milestone set to Adblock-Plus-3.4-for-Chrome-Opera-Firefox

comment:6 Changed on 11/13/2018 at 11:36:06 AM by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tlucas.
Note: See TracTickets for help on using tickets.