Changes between Initial Version and Version 2 of Ticket #7086


Ignore:
Timestamp:
10/31/2018 02:37:12 AM (12 months ago)
Author:
erikvold
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7086

    • Property Cc mjethani sebastian added
  • Ticket #7086 – Description

    initial v2  
    55there was a change made to a regular expression here: https://gitlab.com/eyeo/adblockplus/adblockpluscore/commit/ee3158dca717452047320cb69a80a59513997c71#8525ff79982a26589c57c020069186faa286b695_163_163 
    66 
    7 by changing a `\w+` bit for a `.*?` bit, for which no tests were added, also the `?` in `.*?` is redundant. 
     7by changing a `\w+` bit for a `.*?` bit, for which no tests were added. 
    88 
    99The change adds support for special comments like ` !  : blah` or ` ! *** : foo` by simply ignoring it, this comment previously would've been treated as a filter rule and any special comments after it would've been treated as a filter rule too.  I'm not saying it's a bad change, but it is a change for which no test was added, so if the change was intentional then we should add a test for this.