Changes between Initial Version and Version 1 of Ticket #7101, comment 8


Ignore:
Timestamp:
11/22/2018 12:21:45 AM (12 months ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7101, comment 8

    initial v1  
    1 My idea is to have a standard (single) `mainfest.json` file in `adblockpluschrome` and then have our new (to be written) JavaScript-based packager add/strip platform specific and generated keys when building the extension. Forks like AdBlock can then just provide there own `mainfest.json` base file which should give them sufficient flexibility. 
     1My idea is to have a standard (single) `manifest.json` file in `adblockpluschrome` and then have our new (to be written) JavaScript-based packager add/strip platform specific and generated keys when building the extension. Forks like AdBlock can then just provide their own `manifest.json` base file which should give them sufficient flexibility. 
    22 
    33FWIW, I'm not sure if it makes sense to tackle this before the JavaScript rewrite of `build.py build`. It seems to be a lot of redundant work, to implement this once in Python and then again in JavaScript, and if those two implementations won't be 100% compatible, we end up breaking the configuration mechanism twice which I'd like to avoid.