Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#7107 closed change (fixed)

Update adblockplusui dependency to 2c0512a95dbb (release-2018-4.5)

Reported by: greiner Assignee: greiner
Priority: Unknown Milestone: Adblock-Plus-3.4.1-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: wspee, sebastian Blocked By: #7100
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29939560/

Description (last modified by greiner)

Background

This imports the follow changes:


What to change

Change adblockplusui dependency to hg:2c0512a95dbb git:32136d5.

Change History (10)

comment:1 Changed 12 months ago by greiner

  • Description modified (diff)

comment:2 Changed 12 months ago by greiner

  • Blocked By 7100 added

comment:3 Changed 12 months ago by greiner

  • Cc sebastian added

We'll be updating this ticket as soon as we're done with QA based on our nightlies.

comment:4 Changed 12 months ago by wspee

  • Milestone set to Adblock-Plus-3.4.1-for-Chrome-Opera-Firefox

comment:5 Changed 12 months ago by greiner

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to TBD (release-2018-4.5) to Update adblockplusui dependency to 2c0512a95dbb (release-2018-4.5)

Added hashes to ticket description.

comment:6 Changed 12 months ago by greiner

  • Owner set to greiner

comment:7 Changed 12 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 12 months ago by abpbot

A commit referencing this issue has landed:
Issue 7107 - Updated adblockplusui dependency to 2c0512a95dbb

comment:9 Changed 12 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 12 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. The screenshot is no longer missing edits/marks made by the user if they move backwards through the steps before sending the report. Does not look to have caused any other issues with the issue reporter.

ABP 3.4.0.2189
Firefox 63 / 51 / Windows 8
Chrome 70 / 49 / Windows 8
Opera 36 / 56 / Windows 8

Note: See TracTickets for help on using tickets.