Opened on 11/08/2018 at 09:38:30 PM

Closed on 08/29/2019 at 05:43:52 PM

#7115 closed change (rejected)

Explicitly test expiration parsing

Reported by: ukacar Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: erikvold, rscott, jsonesen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):


We were looking at the tests in the synchronizer.js file and could not find any explicit tests for the expiration special comment parsing.

Attachments (0)

Change History (4)

comment:1 Changed on 11/08/2018 at 09:39:45 PM by rscott

  • Cc rscott added

comment:2 Changed on 03/17/2019 at 10:11:01 AM by mjethani

Could you please describe in a little more detail what exactly we should be testing here? It would be nice to have an example or two.

comment:3 Changed on 03/17/2019 at 10:17:25 AM by mjethani

  • Cc jsonesen added

comment:4 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.