Opened 7 months ago

Closed 5 months ago

Last modified 4 months ago

#7121 closed change (fixed)

Reimplement "build.py updatepsl" as a NodeJS script

Reported by: tlucas Assignee: tlucas
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian, mjethani Blocked By:
Blocking: #6939, #7122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/15

Description (last modified by tlucas)

Background

We currently strive to get rid of python dependencies in adblockpluschrome and adblockpluscore.

What to change

  • Reimplement the logic from $ build.py updatepsl as a NodeJS script $ npm run updatepsl for adblockpluscore

Integration notes

  • Run the new script once, in adblockpluschrome, adjust the requires and mappings for publicSuffixList.js to it's new location in adblockpluscore

Change History (10)

comment:1 Changed 7 months ago by tlucas

  • Blocking 7122 added

comment:2 Changed 7 months ago by tlucas

  • Owner set to tlucas
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 7 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 7 months ago by mjethani

  • Blocking 6939 added

comment:5 Changed 7 months ago by tlucas

  • Cc mjethani added
  • Description modified (diff)
  • Status changed from reviewing to reopened

comment:6 Changed 7 months ago by tlucas

  • Description modified (diff)

comment:7 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 7121 - Move "updatepsl" to core

comment:8 Changed 5 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:9 Changed 5 months ago by mjethani

I think we need to update the modules page to include build/* and data/* in the Automation module.

comment:10 Changed 4 months ago by abpbot

A commit referencing this issue has landed:
Issue 7121 - Move "updatepsl" to core

Note: See TracTickets for help on using tickets.