#7133 closed change (fixed)

Avoid duplicating the test.adblockplus.org filters inside the subscription

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Unknown Keywords:
Cc: sebastian, Ross, ukacar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/testpages.adblockplus.org/merge_requests/4

Description (last modified by kzar)

Background

For https://testpages.adblockplus.org, the filters we are testing are shown both in the related page, and in the testpages filter subscription. So far, they are manually placed in both files. This can lead to mistakes however (e.g. #7131). Let's change it so that the subscription's filters are automatically generated from the filters listed in the test cases.

What to change

Somehow generate the filter subscription file automatically from the filters listed in the test cases. Perhaps it's possible to do this completely automatically, or perhaps the filters will need to be run through a special filter (or similar).

Change History (4)

comment:1 Changed 13 months ago by kzar

  • Description modified (diff)

comment:2 Changed 12 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

I finally got around to doing this! Sorry it took a while.

comment:3 Changed 12 months ago by abpbot

A commit referencing this issue has landed:
Issue 7133 - Avoid duplicating filters in the test subscription

comment:4 Changed 12 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.