Opened 11 months ago

Closed 9 months ago

Last modified 9 months ago

#7146 closed change (fixed)

Add manifest name for release builds

Reported by: wspee Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #7219 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/175

Description (last modified by wspee)

Background

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/257

What to change

Add new string name_releasebuild with the value Adblock Plus - free ad blocker to be used as the name key in the manifest file for release builds.

Change History (13)

comment:1 Changed 11 months ago by wspee

  • Blocked By 7145 added

comment:2 Changed 11 months ago by wspee

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 11 months ago by wspee

  • Blocked By 7145 removed

comment:4 Changed 11 months ago by wspee

  • Blocking 7145 added

comment:5 Changed 10 months ago by wspee

  • Blocking 7145 removed
  • Description modified (diff)

comment:6 Changed 10 months ago by wspee

  • Description modified (diff)
  • Summary changed from Add translation for new chrome extension name used in manifest for cws to Change manifest name for release builds

comment:7 Changed 10 months ago by wspee

  • Description modified (diff)
  • Summary changed from Change manifest name for release builds to Add manifest name for release builds

comment:8 Changed 10 months ago by wspee

  • Blocking 7145 added

comment:9 Changed 9 months ago by wspee

  • Blocking 7219 added

comment:10 Changed 9 months ago by sebastian

  • Blocking 7145 removed

comment:11 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 7146 - Change manifest name for release builds

comment:12 Changed 9 months ago by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:13 Changed 9 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. New name appears in all browsers.

ABP 3.4.2.2231
Chrome 71.0.3578.98 / Windows 10 (Latest)
Chrome 49.0.2623.75 / Windows 10 (Min supported)
Firefox 64.0.2 / Windows 10 (Latest)
Firefox 51.0 / Windows 10 (Min supported)
Opera 57.0.3098.76 / Windows 10 (Latest)
Opera 36.0.2130.65 / Windows 10 (Min supported)

Note: See TracTickets for help on using tickets.