Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#715 closed change (fixed)

Return an UTF-8 string for the PROC_GET_DOCUMENTATION_LINK message

Reported by: fhd Assignee: Mailkov
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://github.com/adblockplus/adblockplusie/pull/3

Description

Background

libadblockplus works with UTF-8 strings, while IE works with UTF-16 strings. Because of this, we need to convert back and forth.

We do most of these conversions in the tab processes, but for the PROC_GET_DOCUMENTATION_LINK message, we're actually expecting an UTF-16 string from the engine process.

What to change

Return an UTF-8 string for the PROC_GET_DOCUMENTATION_LINK message in the engine process (Main.cpp). Convert it to an UTF-16 string in the tab processes (AdblockPlusClient.cpp).

Change History (6)

comment:1 Changed 5 years ago by Mailkov

Hi , I would like to work on this bug

comment:2 Changed 5 years ago by fhd

  • Owner set to Mailkov
  • Platform set to Internet Explorer

Sure!

comment:3 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See TracTickets for help on using tickets.