#7155 closed change (fixed)

Add "popup" content type

Reported by: asmirnov Assignee: zkhetsuriani
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/libadblockplus/merge_requests/32

Description

Background

In AdblockChromium and libadblockplus-android use FilterEngine.matches(https://gitlab.com/eyeo/adblockplus/libadblockplus/blob/master/include/AdblockPlus/FilterEngine.h#L395) to decide if the request should be blocked or not and pass contentTypeMask as argument. popup content type is supported in JS (https://github.com/adblockplus/adblockpluscore/blob/master/lib/filterClasses.js#L952) but not in libadblockplus.

However we need it: https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/38#note_121862751

What to change

Add popup enum value to ContentType:
https://gitlab.com/eyeo/adblockplus/libadblockplus/blob/master/include/AdblockPlus/FilterEngine.h#L199

Change History (3)

comment:1 Changed 12 months ago by zkhetsuriani

  • Owner set to zkhetsuriani

comment:2 Changed 12 months ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 12 months ago by zkhetsuriani

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.