Opened 12 months ago

Closed 12 months ago

Last modified 10 months ago

#7162 closed change (fixed)

Add isWhitelisted method to CombinedMatcher

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29961555/

Description (last modified by mjethani)

Background

In #6940, we made the whitelist property of CombinedMatcher private. lib/filterComposer.js in adblockpluschrome still needs a way to find out if a URL is whitelisted.

What to change

Add a isWhitelisted method to CombinedMatcher. It should call this._whitelist.matchesAny and return a boolean value.

Hints for testers

This is some new code in adblockpluscore, there's nothing to test via the extension (but see #7054).

Change History (5)

comment:1 Changed 12 months ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 12 months ago by abpbot

A commit referencing this issue has landed:
Issue 7162 - Add isWhitelisted method to CombinedMatcher

comment:3 Changed 12 months ago by mjethani

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 7162 - Add isWhitelisted method to CombinedMatcher

comment:5 Changed 10 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.