Opened 7 months ago

Closed 4 months ago

Last modified 3 months ago

#7164 closed change (fixed)

Create test page for sitekey filters

Reported by: Ross Assignee:
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: kzar Blocked By: #7282, #7290
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/testpages.adblockplus.org/merge_requests/6

Description

Background

There are no test pages for testing the sitekey filter option. (There used to be one in the old test pages).

What to change

Create a test page that allows the user to test if sitekey filters are working as expected. The page should consist of:

  • An "ad" element on the page.
  • A frame on the page, containing an "ad" element.
  • A filter that hides the two above elements.
  • The sitekey filter required to unhide the two above elements.

The key part of this issue should already be set up as described in #3339.

Change History (8)

comment:1 Changed 4 months ago by Ross

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 months ago by Ross

  • Ready set

comment:3 Changed 4 months ago by kzar

  • Blocked By 7282 added

comment:4 Changed 4 months ago by abpbot

A commit referencing this issue has landed:
Issue 7164 - Create test page for sitekey filters

comment:5 Changed 4 months ago by kzar

So far this isn't working, but looking into it the extension is failing to verify the given signature. It looks like this is a problem with the sitekey-frame code in sitescripts.

comment:6 Changed 4 months ago by kzar

  • Blocked By 7290 added

comment:7 Changed 4 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 months ago by ubernitt

See #7429

Note: See TracTickets for help on using tickets.